Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add NFT Event Ticketing System #3509

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat: Add NFT Event Ticketing System #3509

wants to merge 9 commits into from
+219 −0

Conversation

JJOptimist
Copy link

@JJOptimist JJOptimist commented Jan 14, 2025 •
edited
Loading

This PR adds a NFT-based event ticketing system.
Screenshot 2025-01-13 205140

  • Create events with configurable parameters (name, description, date, max tickets, price)
  • Purchase tickets using GNOT
  • Tickets are minted as NFTs using GRC721
  • View all events and ticket availability through web interface

Dependencies:

  • gno.land/p/demo/avl
  • gno.land/p/demo/grc/grc721
  • gno.land/p/demo/ufmt

The system demonstrates:

  • Using AVL trees for state management
  • Integration with GRC721 for NFT functionality
  • Handling GNOT payments
  • Web rendering with markdown formatting

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jan 14, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 14, 2025 •
edited
Loading

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: JJOptimist/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

@leohhhn
Copy link
Contributor

leohhhn commented Jan 14, 2025 •
edited
Loading

Hey, check out this issue, it might be interesting: #3482

This is something that is will be a priority for the Gno team and you might be able to help.

@leohhhn
Copy link
Contributor

leohhhn commented Jan 14, 2025

Also, seems you also added your home realm in this PR, which I assume was a mistake.

Please check the CI and see why it's failing :)

@JJOptimist
Copy link
Author

Also, seems you also added your home realm in this PR, which I assume was a mistake.

Please check the CI and see why it's failing :)

(Tried to sneak it in) Yes beginner's mistake, the branch I created already contained my home and I forgot to remove it from the cache before pushing. Ill check the reason why its failing now

@JJOptimist
Copy link
Author

Hey, check out this issue, it might be interesting: #3482

This is something that is will be a priority for the Gno team and you might be able to help.

Thanks for pointing it , I'll look into in

@JJOptimist
Copy link
Author

  • Updated NFT ownership check to properly handle errors
  • Added grc721 import for proper TokenID handling

@leohhhn
Copy link
Contributor

leohhhn commented Jan 14, 2025

Check the CI jobs and their outputs; they'll tell you why they're red

@JJOptimist JJOptimist mentioned this pull request Jan 15, 2025
Open
@notJoon notJoon added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 15, 2025
@Kouteki Kouteki requested a review from leohhhn January 17, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leohhhn leohhhn Awaiting requested review from leohhhn

At least 1 approving review is required to merge this pull request.

Assignees

@JJOptimist JJOptimist

Labels
🧾 package/realm Tag used for new Realms or Packages. review/triage-pending PRs opened by external contributors that are waiting for the 1st review
Projects
🧑‍🎓Student contributors
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JJOptimist @Gno2D2 @leohhhn @notJoon